package web import ( "errors" "io" "net/http" "net/http/httptest" "strings" "testing" "time" "rond-with-you/internal/auth" ) // TestServerErrorHidesDetailFromVisitor 断言 500 响应体不带内部错误详情—— // 公开访客页把 SQL 错误、磁盘路径原样回显,等于免费送出表结构与目录布局。 // 站长自己看得到详情(排查要用),别人只能看到一句人话。 func TestServerErrorHidesDetailFromVisitor(t *testing.T) { s := &Server{} const secret = `pq: relation "zzz_table" does not exist (SQLSTATE 42P01)` anon := httptest.NewRecorder() s.serverError(anon, httptest.NewRequest("GET", "/", nil), errors.New(secret)) if anon.Code != http.StatusInternalServerError { t.Fatalf("状态码应为 500,实际 %d", anon.Code) } if body := anon.Body.String(); strings.Contains(body, "42P01") || strings.Contains(body, "zzz_table") { t.Errorf("访客页泄漏了内部错误详情: %s", body) } owner := httptest.NewRecorder() s.serverError(owner, httptest.NewRequest("GET", "/", nil).WithContext(ctxWithUser(&auth.User{ID: 1})), errors.New(secret)) if body := owner.Body.String(); !strings.Contains(body, "42P01") { t.Errorf("站长应能看到错误详情,实际: %s", body) } } // 半路 panic(首部已提交):不能再写错误页。旧写法无条件 http.Error, // 会二次 WriteHeader(Go 记一条 superfluous response.WriteHeader)并把错误体 // 追加到半个页面后面 —— 用户看到的是「半页正文 + 一句服务器内部错误」。 func TestRecoverLeavesPartialResponseAlone(t *testing.T) { s := &Server{} h := s.recover(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { io.WriteString(w, "
已经写出去的半页
") panic("boom") })) w := httptest.NewRecorder() h.ServeHTTP(w, httptest.NewRequest("GET", "/", nil)) if w.Code != http.StatusOK { t.Errorf("首部已提交就不该再改状态码,实际 %d", w.Code) } body := w.Body.String() if !strings.Contains(body, "已经写出去的半页") { t.Errorf("原有的半页被覆盖了: %q", body) } if strings.Contains(body, "服务器内部错误") { t.Errorf("错误体被追加到了已提交的响应后面: %q", body) } } // 还没写出任何东西就 panic:必须照旧给 500 + 一句人话。 func TestRecoverWritesErrorWhenNothingSent(t *testing.T) { s := &Server{} h := s.recover(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { panic("boom") })) w := httptest.NewRecorder() h.ServeHTTP(w, httptest.NewRequest("GET", "/", nil)) if w.Code != http.StatusInternalServerError { t.Errorf("尚未写出时应回 500,实际 %d", w.Code) } if !strings.Contains(w.Body.String(), "服务器内部错误") { t.Errorf("缺少错误提示: %q", w.Body.String()) } } // 包装层必须实现 Unwrap():否则 http.NewResponseController 在它这里拿不到 // SetWriteDeadline / Flush / Hijack,导出那条路由的 10 分钟写死线会静默失效。 func TestRecoverWrapperUnwraps(t *testing.T) { rec := &deadlineRecorder{ResponseRecorder: httptest.NewRecorder()} s := &Server{} var got error s.recover(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { got = http.NewResponseController(w).SetWriteDeadline(time.Now().Add(time.Minute)) })).ServeHTTP(rec, httptest.NewRequest("GET", "/", nil)) if got != nil { t.Fatalf("ResponseController 没能穿过 recover 的包装: %v", got) } if !rec.got { t.Error("SetWriteDeadline 没有落到真正的 ResponseWriter 上") } }