fix(share): 二维码不再被静默区吃掉三分之一尺寸;卡内间距收到 4px 栅格
上一版改成按模块整数倍出图时,静默区仍然画在图像里:49 个模块(41 + 4×2) 挤进 165px 只剩 3px/模块、符号 111px,比改造前的 135px 还小 —— 这是自己引入的 回归。测试卡上验证时才发现:二维码在 960 宽的卡里只占 111px,微信/QQ 二次 压缩到 480 宽后模块不足 1.5px,gozxing 直接解不出来。 - generateQR 改 qr.DisableBorder:图像只输出符号,静默区交给承载它的白色卡片 (四周留白 30px 以上,远超 4 模块)。符号尺寸按 size/modules 取整,最多 浪费一个模块宽度 - 调用方按实际符号尺寸居中与排版,不再假设等于目标尺寸 - 单题卡 QQRSize 128 → 150:37 模块的题目链接因此拿到 4px/模块(原 3px) - 卡内垂直间距 26/21/21/15 → 24/20/20/16,落在 4px 栅格上 验证:profile 卡二维码 111px → 148px(37 模块 × 4px,用满 90%),单题卡 111px → 148px;gozxing 解码 960 原图、75% 缩放图均能读出正确 URL(含内嵌 头像)。守门测试加了两条:符号宽度必须等于 modules×perModule 且吃掉目标尺寸 ≥80%(变异成「含静默区」立刻 FAIL),头像测试改判四角必须是定位图案而非 白色(防止符号被裁切)。
This commit is contained in:
@@ -141,7 +141,7 @@ func TestDrawTextCenteredIsCentered(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// 内嵌头像不能吃掉静默区(否则扫码器找不到边界),且必须真的画在中心。
|
||||
// 内嵌头像必须画在中心,且符号本身不被裁切(四角是定位图案,应当是黑的)。
|
||||
func TestGenerateQRWithLogo(t *testing.T) {
|
||||
logo := image.NewRGBA(image.Rect(0, 0, 64, 40))
|
||||
draw.Draw(logo, logo.Bounds(), &image.Uniform{color.RGBA{200, 40, 40, 255}}, image.Point{}, draw.Src)
|
||||
@@ -150,14 +150,15 @@ func TestGenerateQRWithLogo(t *testing.T) {
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
r, _, _, _ := img.At(QRCodeSize/2, QRCodeSize/2).RGBA()
|
||||
cx, cy := img.Bounds().Dx()/2, img.Bounds().Dy()/2
|
||||
r, _, _, _ := img.At(cx, cy).RGBA()
|
||||
if r < 0x8000 || r > 0xf000 {
|
||||
t.Errorf("center pixel should be the logo color, got %#x", r)
|
||||
}
|
||||
for _, p := range []image.Point{{0, 0}, {QRCodeSize - 1, 0}, {0, QRCodeSize - 1}, {QRCodeSize - 1, QRCodeSize - 1}} {
|
||||
for _, p := range []image.Point{{0, 0}, {img.Bounds().Dx() - 1, 0}, {0, img.Bounds().Dy() - 1}} {
|
||||
r, g, b, _ := img.At(p.X, p.Y).RGBA()
|
||||
if r != 0xffff || g != 0xffff || b != 0xffff {
|
||||
t.Errorf("quiet zone at %v is not white: %#x %#x %#x", p, r, g, b)
|
||||
if r == 0xffff && g == 0xffff && b == 0xffff {
|
||||
t.Errorf("corner %v is white: finder pattern missing, symbol likely cropped", p)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -170,7 +171,8 @@ func abs(v int) int {
|
||||
}
|
||||
|
||||
// 二维码必须按模块整数倍绘制:任何宽度落差的游程都意味着模块被拉伸,
|
||||
// 小尺寸(微信/QQ 二次压缩后)最容易出现「扫不动」。
|
||||
// 小尺寸(微信/QQ 二次压缩后)最容易出现「扫不动」。同时必须把目标尺寸用满,
|
||||
// 否则模块像素偏小,实际可扫距离大幅缩水。
|
||||
func TestGenerateQRIsModuleAligned(t *testing.T) {
|
||||
const url = "https://box.shiroko.one/_/tamakyi"
|
||||
for _, size := range []int{QRCodeSize, QQRSize} {
|
||||
@@ -178,44 +180,50 @@ func TestGenerateQRIsModuleAligned(t *testing.T) {
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got := img.Bounds().Dx(); got != size {
|
||||
t.Fatalf("size %d: got width %d", size, got)
|
||||
}
|
||||
|
||||
probe, err := qrcode.New(url, qrcode.High)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
probe.DisableBorder = true
|
||||
modules := len(probe.Bitmap())
|
||||
perModule := size / modules
|
||||
if perModule < 1 {
|
||||
t.Fatalf("size %d cannot hold %d modules", size, modules)
|
||||
want := modules * perModule
|
||||
if got := img.Bounds().Dx(); got != want {
|
||||
t.Fatalf("size %d: got width %d, want %d (%d modules x %dpx)", size, got, want, modules, perModule)
|
||||
}
|
||||
if got := img.Bounds().Dy(); got != want {
|
||||
t.Fatalf("size %d: got height %d, want %d", size, got, want)
|
||||
}
|
||||
// 至少用掉目标尺寸的 80%,防止静默区/留白再次吃掉模块像素
|
||||
if float64(want) < 0.8*float64(size) {
|
||||
t.Fatalf("size %d: symbol only %dpx, wastes %.0f%% of the target", size, want, 100*(1-float64(want)/float64(size)))
|
||||
}
|
||||
start := (size - modules*perModule) / 2
|
||||
|
||||
// 中间一行:所有黑白游程(限定在符号区域内)都必须是模块宽度的整数倍
|
||||
y := size / 2
|
||||
runLen := 0
|
||||
for x := start; x < start+modules*perModule; x++ {
|
||||
r, _, _, _ := img.At(x, y).RGBA()
|
||||
black := r < 0x8000
|
||||
if x == start {
|
||||
runLen = 1
|
||||
continue
|
||||
}
|
||||
prevR, _, _, _ := img.At(x-1, y).RGBA()
|
||||
if (prevR < 0x8000) != black {
|
||||
if runLen%perModule != 0 {
|
||||
t.Fatalf("size %d: run of %dpx at x=%d is not a multiple of module %d",
|
||||
size, runLen, x-runLen, perModule)
|
||||
// 逐行扫描:所有黑白游程都必须是模块宽度的整数倍
|
||||
for _, y := range []int{want / 2, want / 3} {
|
||||
runLen := 0
|
||||
for x := 0; x < want; x++ {
|
||||
r, _, _, _ := img.At(x, y).RGBA()
|
||||
black := r < 0x8000
|
||||
if x == 0 {
|
||||
runLen = 1
|
||||
continue
|
||||
}
|
||||
runLen = 1
|
||||
continue
|
||||
prevR, _, _, _ := img.At(x-1, y).RGBA()
|
||||
if (prevR < 0x8000) != black {
|
||||
if runLen%perModule != 0 {
|
||||
t.Fatalf("size %d: run of %dpx at x=%d is not a multiple of module %d",
|
||||
size, runLen, x-runLen, perModule)
|
||||
}
|
||||
runLen = 1
|
||||
continue
|
||||
}
|
||||
runLen++
|
||||
}
|
||||
if runLen%perModule != 0 {
|
||||
t.Fatalf("size %d: trailing run %dpx not a multiple of %d", size, runLen, perModule)
|
||||
}
|
||||
runLen++
|
||||
}
|
||||
if runLen%perModule != 0 {
|
||||
t.Fatalf("size %d: trailing run %dpx not a multiple of %d", size, runLen, perModule)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -250,17 +258,19 @@ func TestShareCardLinkPreview(t *testing.T) {
|
||||
fctx.SetDPI(72)
|
||||
|
||||
lines, size := layoutLink(display)
|
||||
const qrToHintGap, hintLineHeight, hintToSepGap, sepHeight, sepToLinkGap, linkLineHeight = 26, 17, 21, 1, 21, 15
|
||||
total := QRCodeSize + qrToHintGap + hintLineHeight + hintToSepGap + sepHeight + sepToLinkGap + linkLineHeight*len(lines)
|
||||
startY := (QRCardH - total) / 2
|
||||
const qrToHintGap, hintLineHeight, hintToSepGap, sepHeight, sepToLinkGap, linkLineHeight = 24, 17, 20, 1, 20, 16
|
||||
|
||||
qr, err := generateQR("https://"+display, nil, QRCodeSize)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
draw.Draw(canvas, image.Rect(QRCodeX, startY, QRCodeX+QRCodeSize, startY+QRCodeSize), qr, image.Point{}, draw.Over)
|
||||
qrSize := qr.Bounds().Dx()
|
||||
total := qrSize + qrToHintGap + hintLineHeight + hintToSepGap + sepHeight + sepToLinkGap + linkLineHeight*len(lines)
|
||||
startY := (QRCardH - total) / 2
|
||||
|
||||
hintY := startY + QRCodeSize + qrToHintGap + hintLineHeight
|
||||
draw.Draw(canvas, image.Rect((QRCardW-qrSize)/2, startY, (QRCardW+qrSize)/2, startY+qrSize), qr, image.Point{}, draw.Over)
|
||||
|
||||
hintY := startY + qrSize + qrToHintGap + hintLineHeight
|
||||
drawTextCentered(canvas, "扫码向我匿名提问", QRCardW/2, hintY, FontSizeQRHint, ColorHintGray, fctx)
|
||||
sepY := hintY + hintToSepGap
|
||||
drawLine(canvas, QRCardW/2-90, sepY, QRCardW/2+90, sepY, color.NRGBA{200, 200, 200, 180})
|
||||
|
||||
Reference in New Issue
Block a user